Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(CXSPA-8024) - Focus issue on remove button at count 2 #19423

Merged
merged 13 commits into from
Oct 23, 2024
Merged

(CXSPA-8024) - Focus issue on remove button at count 2 #19423

merged 13 commits into from
Oct 23, 2024

Conversation

petarmarkov9449
Copy link
Contributor

@petarmarkov9449 petarmarkov9449 commented Oct 22, 2024 •
edited
Loading

Closes: CXSPA-8024

Remove button stays focused even after activating at count 2.

@petarmarkov9449 petarmarkov9449 requested a review from a team as a code owner October 22, 2024 09:24
@github-actions github-actions bot marked this pull request as draft October 22, 2024 11:17
@petarmarkov9449 petarmarkov9449 marked this pull request as ready for review October 22, 2024 11:44
@cypress Cypress
Copy link

cypress bot commented Oct 22, 2024 •
edited
Loading

spartacus    Run #45467

Run Properties:  status check passed Passed #45467  •  git commit 4e8cb25357 ℹ️: Merge fb435fa17700a866749409575e12d8a3978e1ee5 into de855377d8d065c1a2770aa5ebe2...
Project spartacus
Branch Review feature/CXSPA-8024
Run status status check passed Passed #45467
Run duration 05m 21s
Commit git commit 4e8cb25357 ℹ️: Merge fb435fa17700a866749409575e12d8a3978e1ee5 into de855377d8d065c1a2770aa5ebe2...
Committer petarmarkov9449
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

Pio-Bar
Pio-Bar previously approved these changes Oct 23, 2024
View reviewed changes
Zeyber
Zeyber previously approved these changes Oct 23, 2024
View reviewed changes
developpeurweb
developpeurweb previously approved these changes Oct 23, 2024
View reviewed changes
@github-actions github-actions bot marked this pull request as draft October 23, 2024 15:56
@petarmarkov9449 petarmarkov9449 marked this pull request as ready for review October 23, 2024 16:43
@petarmarkov9449 petarmarkov9449 merged commit f6780fa into develop Oct 23, 2024
28 checks passed
@petarmarkov9449 petarmarkov9449 deleted the feature/CXSPA-8024 branch October 23, 2024 18:39
petarmarkov9449 added a commit that referenced this pull request Oct 23, 2024
@petarmarkov9449
Revert "(CXSPA-8024) - Focus issue on remove button at count 2 (#19423)"
1150979 
This reverts commit f6780fa.
@petarmarkov9449 petarmarkov9449 mentioned this pull request Oct 23, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developpeurweb developpeurweb developpeurweb approved these changes

@Zeyber Zeyber Zeyber left review comments

@Pio-Bar Pio-Bar Pio-Bar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petarmarkov9449 @Zeyber @developpeurweb @Pio-Bar